Fix shuffling an empty Struct() column with UCX #8801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alessandro Bellina <[email protected]>
|
build |
abellina
added
bug
andygrove
reviewed
Jul 25, 2023
| // For example, a Struct column without any members. We treat such a case as if it | ||
| // were a degenerate table. | ||
| if (partSize == 0 && batch.numRows() > 0) { | ||
| sizes(partId) += 100 |
There was a problem hiding this comment.
What is the significance of 100 here? Is this just to ensure that we don't end up with a partition that has zero bytes?
There was a problem hiding this comment.
That's correct. It is an arbitrary number. There is a comment a bit below where it was originally used for the degenerate (no columns) case, and I didn't move that comment up here. I cleaned this up a bit here b159870.
|
build |
revans2
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8784
A new test "test_min_max_in_groupby_and_reduction" exposed a bug in the UCX shuffle for a corner case where a 0-sized column, such as a
Struct()(struct without members) would not be shuffled. This changes the code to make it match what we do for a degenerate column where we still honor the metadata packed by cuDF, but we don't try to transfer 0-sized buffers.